#52392: build: fail patch diff check on subprocess errors
Merged
Description of Change
Updated script/check-patch-diff.ts to fail whenever the patch export subprocess fails, instead of only failing when it exits with status 1.
The script now also handles spawn errors and signal termination, and preserves the subprocess exit status for non-zero exits.
This avoids false-positive successful runs when export_all_patches.py cannot be started or exits with another failure code.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron