#52466: test: fix flaky navigator.hid test on macOS
Merged
- Followup to #52448. That PR unfortunately did not fix the underlying flake because when
select-hid-devicefires it was grabbing the first device returned, even if it was a system device that couldn't be used for the test. There is another testreturns a device when DevicePermissionHandler is definedthat already had logic to only return a valid device instead of the first device, so that check was extracted out to a helper function so that the flaky test can also use that function to get a valid device for testing (if such a device exists).
Assisted-by: Claude Opus 4.8
Description of Change
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron