jkleinsc

#52466: test: fix flaky navigator.hid test on macOS

Merged
Created: Jul 27, 2026, 10:11:01 AM
Merged: Jul 27, 2026, 6:18:31 PM
2 comments
Target: main
  • Followup to #52448. That PR unfortunately did not fix the underlying flake because when select-hid-device fires it was grabbing the first device returned, even if it was a system device that couldn't be used for the test. There is another test returns a device when DevicePermissionHandler is defined that already had logic to only return a valid device instead of the first device, so that check was extracted out to a helper function so that the flaky test can also use that function to get a valid device for testing (if such a device exists).

Assisted-by: Claude Opus 4.8

Description of Change

Checklist

Release Notes

Notes: none

Backports

44-x-y
Merged
PR Number
#52473
Merged At
Jul 27, 2026, 8:32:10 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron