#52577: fix: WCO captions not appearing on Linux
Merged
Description of Change
Resolves #52576.
Restores WCO on Linux in Electron 44 alpha/45 nightly.
This removes the opt-out added with the Chromium roll in #52288. Opting out of Views layer management for occlusion tracking is no longer necessary following https://chromium-review.googlesource.com/c/chromium/src/+/8060981, and it no longer works correctly as of https://chromium-review.googlesource.com/c/chromium/src/+/8117151 and https://chromium-review.googlesource.com/c/chromium/src/+/8111037.
Passes the existing tests in api-web-contents-view-spec that guard against this regression:
tracks visibility for multiple child WebContentsViewstracks visibility independently when a child WebContentsView is hidden via setVisible
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed Window Controls Overlay caption buttons not rendering on Linux.
Backports
44-x-y
In-flightSemver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron