#52600: chore: include the asar entry in integrity-check failure messages
Merged
Description of Change
asar::ValidateIntegrityOrDie() logs only the two hashes when a check
fails, so a crash report from a damaged install ("Integrity check failed
for asar archive ( vs )") can't say which entry - or the
header - failed the check.
Thread a short what label through the three call sites (header
validation, packed-file read, unpacked copy-out) and include it, with the
input size, in the fatal message. Message text only; no behavior change.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - tests are changed or added
- relevant documentation, tutorials, templates and examples are changed or are not needed
Release Notes
Notes: Improved the error message when an asar integrity check fails to name the entry that failed.
Backports
42-x-y
MergedPR Number
#52623Merged At
Aug 4, 2026, 10:02:59 AM
Released In
v42.8.1Release Date
Aug 4, 2026, 11:00:22 AM
43-x-y
MergedPR Number
#52622Merged At
Aug 4, 2026, 10:35:15 AM
Released In
v43.3.0Release Date
Aug 4, 2026, 11:00:22 AM
44-x-y
MergedPR Number
#52624Merged At
Aug 4, 2026, 10:03:55 AM
Released In
v44.0.0-beta.1Release Date
Aug 5, 2026, 6:16:48 PM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron