#52764: fix: don't crash on invalid reason for promptTouchID
Merged
Description of Change
Fixes an empty or non-UTF8 value for systemPreferences.promptTouchID(reason) causing a crash with NSInvalidArgumentException. This was flagged by the clang-analyzer-nullability.NullablePassedToNonnull check in clang-tidy.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash in systemPreferences.promptTouchID(reason) when an invalid reason value is passed
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron