#52773: fix: don't crash on non-UTF8 serviceName in app.setLoginItemSettings
Merged
Description of Change
This was flagged by clang-analyzer-nullability.NullablePassedToNonnull. Without the fix the new test case results in a SIGSEGV.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash with app.setLoginItemSettings if a non-UTF8 service name is used
Backports
42-x-y
PendingWaiting for a manual backport
43-x-y
PendingWaiting for a manual backport
44-x-y
In-flightSemver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron