alicelovescake

#52805: ci: dedupe the typescript-go fix-sync step

Merged
Created: Aug 13, 2026, 11:51:29 AM
Merged: Aug 14, 2026, 1:44:30 AM
1 comments
Target: main

Description of Change

Follow-up to #52612 (comment) (@dsanders11's suggestion): collapse the two per-arch Fix typescript-go (macOS …) steps in .github/actions/fix-sync into one.

CIPD's ${platform} templating can't be used here the way the gn step uses mac-${arch}: the Chromium DEPS entries for tsgo are literal per-arch keys (src/third_party/typescript/mac-arm64/src / mac-amd64/src) with literal package names, and cipd-install needs the exact DEPS key for gclient getdep as well as a concrete installation dir. So the arch is picked with a runner.arch == 'ARM64' && 'mac-arm64' || 'mac-amd64' expression instead. Behaviour is unchanged.

Checklist

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron