MarshallOfSound

#52823: fix: inherit nodeIntegrationInWorker from the embedder for <webview> and window.open

Merged
Created: Aug 15, 2026, 4:20:25 PM
Merged: Aug 15, 2026, 6:05:34 PM
5 comments
Target: main

The <webview> guest-inheritance list clamps a guest to be no less restricted than its embedder for nodeIntegration, contextIsolation, sandbox, and friends, but nodeIntegrationInWorker was missing — so a webpreferences="nodeIntegrationInWorker=1" attribute was honoured even when the embedder had it off. nodeIntegrationInWorker was also absent from getLastWebPreferences(), so the inheritance check had nothing to compare against.

  • Add nodeIntegrationInWorker to the inherited web preferences for <webview> (and the equivalent window.open list).
  • Emit nodeIntegrationInWorker from SaveLastPreferences() so it round-trips through getLastWebPreferences(), matching nodeIntegration.
  • Document the <webview> inheritance behaviour; add regression coverage.

Notes: <webview> and window.open now inherit nodeIntegrationInWorker from the embedder, consistent with the other Node and sandbox preferences.

Backports

41-x-y
In-flight
PR Number
#52829
Waiting to be merged
42-x-y
Merged
PR Number
#52831
Merged At
Aug 15, 2026, 7:33:40 PM
Released In
Not yet
Release Date
Not yet
43-x-y
Merged
PR Number
#52830
Merged At
Aug 15, 2026, 7:34:56 PM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#52832
Merged At
Aug 15, 2026, 7:30:11 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron