codebytere

#52954: refactor: use upstream dropdown color ids for the datalist popup

Merged
Created: Aug 18, 2026, 4:29:52 AM
Merged: Aug 19, 2026, 2:40:40 AM
1 comments
Target: main

Description of Change

Closes #31697

Our <datalist> popup painted with kColorResultsTable* and kColorUnfocusedBorder, ids that Chromium removed in CL 1652925 and that we've been patching back into //ui/color ever since. Chrome's own autofill popup uses ui::kColorDropdown* these days, so this points ours at those (plus kColorLabelForegroundSecondary for the label and kColorMenuBorder for the border) and drops port_autofill_colors_to_the_color_pipeline.patch.

On Linux the popup now follows the GTK combobox colors, selected row included. Also removes the components/autofill features include and GN dep, unused since #36394.

Checklist

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron