#53032: build: enable Clang Static Analyzer clang-tidy checks
Merged
Description of Change
This enables a bunch of clang-analyzer-* (static analysis) checks in clang-tidy and fixes the errors that popped out. The fixes are mostly separated out by commit with the check name, but some fixes went into the original commit as they were trivial or // NOLINT.
Other fixes from these checks were spun off into their own PRs when feasible and test coverage for the underlying issue was added when possible:
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron