MarshallOfSound

#53062: test: deflake test-worker-stack-overflow-stack-size in the Node.js suite

Merged
Created: Aug 21, 2026, 1:40:39 AM
Merged: Aug 21, 2026, 4:56:52 AM
5 comments
Target: main

Description of Change

  • Backports nodejs/node#64271 as a patches/node patch. parallel/test-worker-stack-overflow-stack-size compares the recursion depth two Workers reach before overflowing; depth also depends on frame size, which changes if the recursive function tiers up mid-recursion, so on a loaded runner the two depths land >10% apart (e.g. w1stack = 62263, w2stack = 82360 are too far apart in this nn-test run). The upstream fix pins the function to the interpreter with %NeverOptimizeFunction.
  • The fix only shipped in Node 26.6.0+; every active branch is on 24.18.x, hence the patch + backport labels. It drops out at the next Node roll that includes it.
  • Locally under CPU load: unpatched failed 2/30 with the same assertion, patched passed 30/30.

Checklist

  • PR description included

Release Notes

Notes: none

Backports

41-x-y
Merged
PR Number
#53075
Merged At
Aug 21, 2026, 6:01:21 AM
Released In
Not yet
Release Date
Not yet
42-x-y
Merged
PR Number
#53076
Merged At
Aug 21, 2026, 6:01:35 AM
Released In
Not yet
Release Date
Not yet
43-x-y
Merged
PR Number
#53078
Merged At
Aug 21, 2026, 6:02:36 AM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#53077
Merged At
Aug 21, 2026, 6:01:51 AM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron