#53071: chore: fix clang-tidy dead-store warning in browser_win.cc
Merged
Description of Change
windows-x64 / clang-tidy is currently red on every open PR with clang-analyzer-deadcode.DeadStores at shell/browser/browser_win.cc:233: RegQueryValueEx was passed &(size = sizeof(startup_binary)), and the analyzer cannot see the value being read back through the pointer. Initialize size on its own line and pass &size; behaviour is identical.
Checklist
- PR description included and stakeholders cc'd
- I have reviewed and verified the changes
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron