#53102: fix: avoid creating webFrameMain for transient frames
Merged
Description of Change
- Fixes #53068. This issue was exposed due to the changes in #52217
This fix preventsWebFrameMainfrom being created for a speculative or pending-commitRenderFrameHost. If no wrapper exists during a frame swap, Electron now initializes one from the current active frame and updates it when the swap completes.
Also, added a regression test for the fixed issue.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash when accessing frame details during cross-origin navigation.
Backports
44-x-y
In-flightSemver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron