#53253: build: type check specs in docs-only CI
Merged
Description of Change
We got burned by #53248 being a docs-only change that broke typings in our tests, and since the tests aren't run for docs-only and we also didn't type check them, there was no way to catch that in CI before merge.
This PR also includes a couple of minor changes in the smoke tests since they weren't type checking cleanly due to a few unused variables.
Checklist
- I have built and tested this change
- I have filled out the PR description
Release Notes
Notes: none
Backports
43-x-y
PendingWaiting for a manual backport
44-x-y
PendingWaiting for a manual backport
45-x-y
In-flightSemver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron