MarshallOfSound

#53306: docs: require symbol-level attribution in the node upgrade skill

Merged
Created: Aug 29, 2026, 2:23:25 AM
Merged: Aug 31, 2026, 10:15:21 AM
4 comments
Target: main

Description of Change

Tightens the electron-node-upgrade skill so patch-fix commits on node roller branches cite the right upstream change.

  • references/phase-one-commit-guidelines.md: replace "use git log or git blame" with a required procedure. Name the symbol the fix touches, find its introducing commit with git log -S or git blame against refs/patches/upstream-head, verify that commit's diff contains the symbol, then take its PR-URL: and use its subject line verbatim as the title. Recency queries like git log -10 -- file are explicitly not attribution.
  • references/phase-one-commit-guidelines.md: new "Reuse Fixes From Sibling Roller Branches" section. Check roller/node/main and sibling roller/node/{N}-x-y branches for the same version first and reuse patch names, content, titles and refs verbatim.
  • references/patch-analysis.md: same procedure in the "Finding the Upstream Commit for a Change" section, and a note that the recent-history step is for orientation only.
  • references/phase-two-commit-guidelines.md: point at the phase-one procedure and the sibling-branch check.
  • SKILL.md: pre-flight item to look for the same roll on other branches.

Prompted by #53250, where the guard for ReadASN1Element was attributed to nodejs/node#64547 (the newest commit touching ncrypto.cc) instead of nodejs/node#64211 (the commit that added it), and where the same JSPI fix landed under a different patch name than on main and 43-x-y.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

Backports

43-x-y
Merged
PR Number
#53322
Merged At
Aug 31, 2026, 10:27:17 AM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#53324
Merged At
Aug 31, 2026, 10:28:15 AM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#53323
Merged At
Aug 31, 2026, 10:27:42 AM
Released In
v45.0.0-alpha.3
Release Date
Aug 31, 2026, 3:00:16 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron