jkleinsc

#53336: build: remove requirement of empty commit message body

Merged
Created: Aug 31, 2026, 10:57:35 AM
Merged: Aug 31, 2026, 3:57:08 PM
4 comments
Target: main

Description of Change

The chromium roller commit linting was failing on a commit like this:

chore: update patches
Signed-off-by: John Kleinschmidt <jkleinsc@electronjs.org>

This should be a valid commit. The Signed-off-by gets added to the commit when a commit is signed off via git commit --amend --signoff or git rebase -i --signoff HEAD~n

Checklist

Release Notes

Notes: none

Backports

44-x-y
Merged
PR Number
#53347
Merged At
Aug 31, 2026, 5:10:58 PM
Released In
v44.1.1
Release Date
Sep 1, 2026, 11:00:23 AM
45-x-y
Merged
PR Number
#53346
Merged At
Aug 31, 2026, 5:12:18 PM
Released In
v45.0.0-alpha.4
Release Date
Sep 3, 2026, 3:00:16 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron