This is a backport PR for branch 43-x-y
MarshallOfSound

#53374: fix: settle pending upload stream reads when a net.request ends

Open
Created: Sep 1, 2026, 11:14:47 AM
0 comments
Target: 43-x-y

Backport of #53341

See that PR for details. Differences from main: the observer overrides Chromium 153 removed (OnSharedStorageHeaderReceived, OnAdAuctionEventRecordHeaderReceived) are kept on the new SimpleURLLoaderClient since this line's Chromium still has them, and OnCertificateRequested stays the no-op it always was here because the net select-client-certificate support (#52162) is not on 43-x-y.

Notes: Fixed a pending read on a net.request chunked upload stream inside a protocol handler never settling when the request failed or was aborted.

Backport Information

Original PR Author
MarshallOfSound
Original PR Status
Merged
Original PR Merged At
Sep 1, 2026, 10:31:43 AM
Original PR Link
GitHubView on GitHub

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron