MarshallOfSound

#53383: test: stop asserting inside stdio listeners in the utilityProcess spec

Merged
Created: Sep 1, 2026, 5:11:53 PM
Merged: Sep 2, 2026, 1:44:59 PM
7 comments
Target: main

Description of Change

  • Three utilityProcess tests attached one 'data' listener to both stdout and stderr of a child and called expect() inside it. A failing expect in a stream listener is an uncaught exception, so the spec runner exits with no summary and no JUnit file rather than reporting one red test. That is what took down the mac shard on this run: a net/dns "Failed to read DnsConfig" warning on stderr beat the fixture's stdout to the --dns-result-order test's first chunk.
  • The dns test now reads stdout only and asserts after the fixture exits, since the fixture prints one line and exits on its own.
  • The two --inspect tests collect output until the inspector's "Debugger listening" line appears, kill the child, wait for exit, and assert afterwards.

Checklist

Release Notes

Notes: none

Backports

43-x-y
Merged
PR Number
#53411
Merged At
Sep 2, 2026, 6:52:03 PM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#53410
Merged At
Sep 2, 2026, 6:52:49 PM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#53412
Merged At
Sep 2, 2026, 4:03:32 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron