#53383: test: stop asserting inside stdio listeners in the utilityProcess spec
Merged
Created: Sep 1, 2026, 5:11:53 PM
Merged: Sep 2, 2026, 1:44:59 PM
7 comments
Target: main
Description of Change
- Three
utilityProcesstests attached one'data'listener to both stdout and stderr of a child and calledexpect()inside it. A failingexpectin a stream listener is an uncaught exception, so the spec runner exits with no summary and no JUnit file rather than reporting one red test. That is what took down the mac shard on this run: anet/dns"Failed to read DnsConfig" warning on stderr beat the fixture's stdout to the--dns-result-ordertest's first chunk. - The dns test now reads stdout only and asserts after the fixture exits, since the fixture prints one line and exits on its own.
- The two
--inspecttests collect output until the inspector's "Debugger listening" line appears, kill the child, wait for exit, and assert afterwards.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron