#53450: build: pin the siso revision in build/siso_revision instead of fetching Chromium's DEPS in CI
Merged
Created: Sep 3, 2026, 3:25:27 AM
Merged: Sep 3, 2026, 12:06:54 PM
7 comments
Target: main
Description of Change
pipeline-segment-build-siso needs the siso commit that our pinned Chromium expects. Until now it curled Chromium's DEPS from raw.githubusercontent.com on every run to find it, and that fetch has failed main several times recently (HTTP errors and a TLS reset; on 09-02 it took out all three siso jobs in one run). The value only changes when Chromium rolls, so this records it in the repo and removes the fetch entirely:
build/siso_revisionholds the sha. The build-siso job reads it from its sparse checkout; no network involved in resolving it any more.script/gen-siso-revision.jsderives the value from the synced Chromium tree (siso_versioninsrc/DEPS). It runs as agen_siso_revisiongclient hook after every sync, from lint-staged whenDEPSchanges, and with--checkin the gn-check job so a roll that forgets to commit the updated file fails with a message saying exactly what to do.script/lint-roller-chromium-changes.mjsaccepts achore: update siso revisioncommit that touches only that file, and the Chromium upgrade skill/commit guidelines say to make that commit after a successfule sync --3— same treatment asfilenames.libcxx.gni.
Seeded with the revision for the currently pinned Chromium (155.0.8038.2 → efbbe7f18922…). Release branches keep the old curl step until this is backported.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron