codebytere

#53526: test: keep the Node.js flaky-test list in the spec runner

Merged
Created: Sep 4, 2026, 8:45:48 AM
Merged: Sep 4, 2026, 11:46:48 AM
3 comments
Target: main

Description of Change

The list of Node.js tests we treat as flaky lived in a patch to Node's parallel.status / sequential.status / test-runner.status files. It now lives in script/node-flaky-tests.json next to node-disabled-tests.json, and script/node-spec-runner.js appends it to the suite's test/root.status as PASS,FLAKY for the duration of the run (restored afterwards, with the same backup-file mechanism the runner already uses for the stray package.json files it moves aside). tools/test.py --flaky-tests=dontcare picks the entries up exactly as before, so the tests keep running without failing CI.

  • test-diagnostics-channel-memory-leak was a plain SKIP in the patch and moves to node-disabled-tests.json.
  • test-inspector-stop-profile-after-done was listed under sequential/ in the patch but lives in parallel/ on v24, so the old entry never matched; the JSON entry points at the right file.
  • --validateDisabled now checks the flaky entries exist too.

Checklist

Release Notes

Notes: none

Backports

44-x-y
In-flight
PR Number
#53534
Waiting to be merged
45-x-y
In-flight
PR Number
#53533
Waiting to be merged

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron