MarshallOfSound

#53666: fix: scope File System Access grants to the requesting document

Merged
Created: Sep 7, 2026, 4:05:50 AM
Merged: Sep 7, 2026, 12:14:20 PM
8 comments
Target: main
  • A cross-origin iframe can no longer request more File System Access permission than it already has (the third-party check compared the requester with itself); matches Chrome.
  • file-system-access-restricted is emitted once per requesting document, with details.frame and details.webContents, instead of once per path with the first requester's origin.
  • Active grants for an origin are reset shortly after its last top-level document closes or navigates away, and kept while another is open; the helper that drives this was never attached.
  • In-memory partitions get a File System Access permission context; without one, write access was always denied and the handlers never ran.

Notes: File System Access permission requests and the file-system-access-restricted event are scoped to the requesting document, grants are reset when the origin's last page closes, and write access works in in-memory sessions.

Backports

42-x-y
In-flight
PR Number
#53695
Waiting to be merged
43-x-y
Merged
PR Number
#53694
Merged At
Sep 7, 2026, 2:42:30 PM
Released In
Not yet
Release Date
Not yet
44-x-y
In-flight
PR Number
#53691
Waiting to be merged
45-x-y
Merged
PR Number
#53690
Merged At
Sep 7, 2026, 1:35:42 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron