MarshallOfSound

#53682: fix: attribute openExternal permission requests to the navigation's initiator

Merged
Created: Sep 7, 2026, 10:59:21 AM
Merged: Sep 7, 2026, 12:53:08 PM
5 comments
Target: main
  • When the document that started a navigation to an external protocol no longer exists, the openExternal permission request is reported with that document's origin (captured when the request reached the browser) as requestingUrl, instead of whatever the navigating WebContents has committed; isMainFrame then describes the navigating frame.
  • Live initiators and direct browser-initiated navigations are attributed exactly as before; the request's user gesture is now passed through.
  • Specs for detached initiators, redirects and browser-initiated navigations.

Notes: openExternal permission requests started by a frame that has since gone away are attributed to that frame's origin rather than to the navigating page.

Backports

42-x-y
Merged
PR Number
#53697
Merged At
Sep 7, 2026, 2:21:39 PM
Released In
Not yet
Release Date
Not yet
43-x-y
Merged
PR Number
#53698
Merged At
Sep 7, 2026, 2:37:26 PM
Released In
Not yet
Release Date
Not yet
44-x-y
In-flight
PR Number
#53699
Waiting to be merged
45-x-y
In-flight
PR Number
#53696
Waiting to be merged

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron