codebytere

#53829: build: drop the EngFlow reclient-configs dependency

Merged
Created: Sep 11, 2026, 3:19:45 AM
Merged: Sep 11, 2026, 7:46:02 PM
1 comments
Target: main

Description of Change

Remote clang steps from macOS and Windows hosts run a Linux clang on the RBE workers through clang_remote_wrapper. That wrapper, the Linux clang download and the rewrapper_{mac,windows}.cfg Chromium's GN and siso config check for were the last things we still took from EngFlow's reclient-configs: a DEPS checkout, two patches on it, a Chromium patch chaining its generator behind Chromium's configure_reclient_cfgs hook, and CI steps that installed the reclient binaries and reran the generator on the macOS and Windows runners. Nothing runs reproxy or rewrapper anymore.

As of electron/build-tools#904, e sync and e build stage the Linux clang, install the wrapper and write the stub cfgs themselves, so this bumps BUILD_TOOLS_SHA to that merge and removes:

  • the src/third_party/engflow-reclient-configs DEPS entry, patches/reclient-configs and its patches/config.json row
  • build_run_reclient_cfg_generator_after_chrome.patch, and the EngFlow line from the third_party .gitignore patch
  • fix-sync's "Fix reclient" and "Configure reclient configs" steps, and the matching steps in the macOS clang-tidy job, which now fetches the Linux clang-tidy after e build --gen=only has staged the Linux clang it sits next to

All four macOS and Windows build jobs and the macOS clang-tidy job pass here with e build staging the Linux clang itself; object change rate against main is 0.01-0.02%. The first builds miss the remote cache because the wrapper's contents changed.

Checklist

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron