dsanders11

#53854: fix: potential UAF in GetPreferredLanguages on Windows

Merged
Created: Sep 12, 2026, 3:52:16 AM
Merged: Sep 12, 2026, 6:31:15 PM
4 comments
Target: main

Description of Change

In practice this hasn't bit us as langs is keeping the memory alive, but we can't rely on that, so refactor to remove the latent UAF.

Checklist

Release Notes

Notes: Fixed a potential UAF in app.getPreferredSystemLanguages() on Windows

Backports

43-x-y
In-flight
PR Number
#53866
Waiting to be merged
44-x-y
Merged
PR Number
#53865
Merged At
Sep 12, 2026, 7:24:08 PM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#53864
Merged At
Sep 12, 2026, 7:26:06 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron