MarshallOfSound

#53890: build: let script/lint.js skip ignore roots that are not directories

Merged
Created: Sep 13, 2026, 3:51:04 PM
Merged: Sep 14, 2026, 12:01:51 AM
5 comments
Target: main

Description of Change

In a git worktree .git is a file, so the markdown linter's .git ignore root made findMatchingFiles() throw ENOTDIR and npm run lint:docs (and the pre-commit hook) fail. Skip ignore roots that are not directories.

Checklist

Release Notes

Notes: none

Backports

42-x-y
Merged
PR Number
#53898
Merged At
Sep 14, 2026, 12:59:51 AM
Released In
Not yet
Release Date
Not yet
43-x-y
Merged
PR Number
#53895
Merged At
Sep 14, 2026, 1:01:32 AM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#53896
Merged At
Sep 14, 2026, 12:56:28 AM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#53897
Merged At
Sep 14, 2026, 1:00:41 AM
Released In
v45.0.0-alpha.7
Release Date
Sep 14, 2026, 3:00:17 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron