codebytere

#53902: chore: fix four small defects in carried Chromium patches

Merged
Created: Sep 14, 2026, 4:16:44 AM
Merged: Sep 14, 2026, 12:55:25 PM
1 comments
Target: main

Description of Change

Four small corrections to carried Chromium patches, one per commit. None changes Electron's behavior except the first, which restores a call that was disabled on every macOS build instead of only MAS.

  • mas_avoid_private_macos_api_usage: -[BrowserNativeWidgetWindow setAlwaysShowTrafficLights:] was commented out unconditionally; BrowserWindowFrame is only compiled out under IS_MAS_BUILD(), so the call is now guarded with that instead.
  • feat_separate_content_settings_callback_for_sync_and_async_clipboard added GEOLOCATION_APPROXIMATE cases upstream already has, which refactor_patch_electron_permissiontypes_into_blink then removed, so the first patch did not compile on its own. It now adds only the DEPRECATED_SYNC_CLIPBOARD_READ cases, and the run-on lines both patches left in those switch statements are fixed. The resulting tree differs only in whitespace.
  • expose_gtk_ui_platform_field carried the callback_helpers.h include in extensions/renderer/script_injection.cc that belongs to fix_return_v8_value_from_localframe_requestexecutescript (for its base::NullCallback()); moved there.
  • fix_pulseaudio_stream_and_icon_names included electron/ headers from //content and //media and called into Electron when launching the audio service. ElectronBrowserMainParts now exports ELECTRON_PA_APP_NAME and ELECTRON_PA_ICON_NAME on Linux before ready; media/audio/pulse reads them with getenv and falls back to the upstream names when unset. The //content hunk is gone.

Verified on Linux: e build; the clipboard, extension content-script and executeJavaScript specs pass; a test app with app.setName('PulseNameCheck') sees both variables set at ready. The series was regenerated from refs/patches/upstream-head and only these six patch files change.

Checklist

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron