#53902: chore: fix four small defects in carried Chromium patches
Description of Change
Four small corrections to carried Chromium patches, one per commit. None changes Electron's behavior except the first, which restores a call that was disabled on every macOS build instead of only MAS.
mas_avoid_private_macos_api_usage:-[BrowserNativeWidgetWindow setAlwaysShowTrafficLights:]was commented out unconditionally;BrowserWindowFrameis only compiled out underIS_MAS_BUILD(), so the call is now guarded with that instead.feat_separate_content_settings_callback_for_sync_and_async_clipboardaddedGEOLOCATION_APPROXIMATEcases upstream already has, whichrefactor_patch_electron_permissiontypes_into_blinkthen removed, so the first patch did not compile on its own. It now adds only theDEPRECATED_SYNC_CLIPBOARD_READcases, and the run-on lines both patches left in those switch statements are fixed. The resulting tree differs only in whitespace.expose_gtk_ui_platform_fieldcarried thecallback_helpers.hinclude inextensions/renderer/script_injection.ccthat belongs tofix_return_v8_value_from_localframe_requestexecutescript(for itsbase::NullCallback()); moved there.fix_pulseaudio_stream_and_icon_namesincludedelectron/headers from//contentand//mediaand called into Electron when launching the audio service.ElectronBrowserMainPartsnow exportsELECTRON_PA_APP_NAMEandELECTRON_PA_ICON_NAMEon Linux beforeready;media/audio/pulsereads them withgetenvand falls back to the upstream names when unset. The//contenthunk is gone.
Verified on Linux: e build; the clipboard, extension content-script and executeJavaScript specs pass; a test app with app.setName('PulseNameCheck') sees both variables set at ready. The series was regenerated from refs/patches/upstream-head and only these six patch files change.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - I have reviewed and verified the changes
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron