codebytere

#53990: build: squash the perfetto backports into one Node.js patch

Merged
Created: Sep 16, 2026, 5:56:08 AM
Merged: Sep 16, 2026, 11:17:59 AM
4 comments
Target: main

Description of Change

The perfetto trace agent came into patches/node as six separate cherry-picks of nodejs/node#64565 and nodejs/node#64721. Both are marked dont-land-on-v24.x upstream, so they stay for as long as Electron ships Node.js 24; this carries them as one patch instead. It also folds the CleanupHookThunkRun regression test into the patch for its fix, matching how nodejs/node#65630 landed.

The patched Node.js tree is byte-identical before and after (verified by re-applying the series to v24.21.0 and diffing); patches/node goes from 58 files to 52.

Checklist

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron