#54015: build: run clang-tidy on Electron's headers
Merged
Description of Change
Surface clang-tidy warnings for our headers as well, and fix up the dozen or so existing failures. This also disables bugprone-forward-declaration-namespace for now as it sometimes incorrectly reports issues in upstream code despite the header filter.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron