MarshallOfSound

#54075: test: turn accessibility back off after the app a11y specs

Merged
Created: Sep 17, 2026, 11:50:42 PM
Merged: Sep 18, 2026, 1:01:41 AM
4 comments
Target: main

Description of Change

Before: the app module > accessibility support functionality specs set a process-wide AXMode and the last one leaves nativeAPIs | webContents | inlineTextBoxes | extendedProperties on. On macOS and Windows every spec that runs after api-app-spec in the same shard therefore runs with renderer accessibility enabled. That is how a 43-x-y macos-arm64 / test (darwin, 2) run hit Chromium's DCHECK(GetAXTreeID().token()) in RenderFrameHostImpl::BindRenderAccessibilityHost ~950 tests later and SIGABRT'd the whole shard (job). Upstream keeps that as a DCHECK precisely because it still fires in the field (crbug.com/500881532, crbug.com/526541651).

After: accessibility is switched back off after each of those specs, so the rest of the suite runs with AXMode off as it does on Linux.

How: an afterEach in that describe block calling app.setAccessibilitySupportEnabled(false), which resets the scoped process mode set by either setter.

Checklist

Release Notes

Notes: none

Backports

43-x-y
Merged
PR Number
#54078
Merged At
Sep 18, 2026, 2:05:21 AM
Released In
v43.7.3
Release Date
Sep 18, 2026, 9:13:36 AM
44-x-y
Merged
PR Number
#54077
Merged At
Sep 18, 2026, 2:04:50 AM
Released In
v44.4.3
Release Date
Sep 18, 2026, 9:13:28 AM
45-x-y
Merged
PR Number
#54076
Merged At
Sep 18, 2026, 2:08:05 AM
Released In
v45.0.0-alpha.9
Release Date
Sep 18, 2026, 9:13:09 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron