MarshallOfSound

#54139: build: update @electron/lint-roller to 4.0.0

Merged
Created: Sep 19, 2026, 6:31:00 PM
Merged: Sep 21, 2026, 2:18:38 AM
8 comments
Target: main

Description of Change

Before: the JS code blocks in docs/ were linted by lint-roller-markdown-standard, which pulled the whole eslint/standard tree into yarn.lock, and lint:docs-fiddles ran the standard binary that only existed because lint-roller 3 depended on it.

After: lint-roller 4.0.0 lints those blocks with the repo's own oxlint and .oxlintrc.json via lint-roller-markdown-oxlint, lint:docs-fiddles runs oxlint over docs/fiddles, and yarn.lock loses roughly 1,900 lines.

The fiddle changes are the handful of findings oxlint surfaced (unused trailing callback parameters, one bare require('path'), one stale eslint-disable comment), with the one tutorial that inlines an affected fiddle kept in sync. The <!-- eslint-... --> HTML comments in docs were directives for the old linter and are dropped. The oxfmt half of the split (formatting the code blocks) follows in a separate PR stacked on this one.

Checklist

Release Notes

Notes: none


Generated by Claude Code

Backports

42-x-y
In-flight
PR Number
#54160
Waiting to be merged
43-x-y
In-flight
PR Number
#54159
Waiting to be merged
44-x-y
In-flight
PR Number
#54158
Waiting to be merged
45-x-y
In-flight
PR Number
#54157
Waiting to be merged

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron