Electron Releases

Back to PR Lookup
GitHubView on GitHub
MarshallOfSound

#54247: build: fail gn gen if the V8 code-cache salt comes out empty

Merged
MarshallOfSound
Created: Sep 23, 2026, 3:05:34 PM
Merged: Sep 23, 2026, 4:34:37 PM
3 comments
Target: main

Description of Change

Follow-up to #54234.

Before: if gni/version_hash_salt.gni ever hands v8/BUILD.gn an empty v8_version_hash_salt while v8_version_hash_salt_files is populated, the build silently ships without the salt, which is the exact guarantee #54234 exists to provide. I saw one gn gen do this while preparing the release-branch backports (the very next gen in the same tree was fine and it has not reproduced since).

After: gn gen asserts that a populated v8_version_hash_salt_files produced a non-empty salt, so the failure mode is a red gen step rather than an unsalted release.

  • patches/v8/feat_key_code_caches_to_the_patch_set_and_the_embedded_blob.patch: one assert() next to the write_file(). The manual 42/43/44 backports (#54239, #54238, #54246) already include it.

Checklist

Release Notes

Notes: none

Backports

45-x-y
Merged
PR Number
#54260
Merged At
Sep 23, 2026, 8:01:54 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron