This is a backport PR for branch 42-x-y
ckerr

#54722: test: wait for child output before asserting on it

Merged
Created: Oct 7, 2026, 2:21:27 PM
Merged: Oct 14, 2026, 7:27:35 PM
2 comments
Target: 42-x-y

Description of Change

Manually backport #54507.

See that PR for details.

Backport notes

Cherry-picked from the 43-x-y backport, #54543, which conflicts less than the original.

  • spec/node.spec.ts: dropped the hunk for the process.exit tests, which 42-x-y doesn't have.
  • spec/lib/msix-helpers.ts: 42-x-y still has the callback form of spawn(), because #53426's conversion is in its own backport PR. I applied the same 'exit' to 'close' change to that form. Whichever of the two PRs merges second needs a one-line rebase there.

Validation

On a Linux testing build of 42-x-y (v42.11.12):

  • e test on all 12 changed spec files: 1081 passed, 7 failed.
  • The same 7 tests fail the same way on unmodified 42-x-y on this machine, so this change didn't cause them. They are --lang (×3), window.open child size, document.hasFocus, the protocol.handle "is fast" ratio, and the js2c fuse test, which needs chrome-sandbox.
  • tsc -p tsconfig.spec.json passes.

🤖 Generated with Claude Code

Checklist

Release Notes

Notes: none

Backport Information

Original PR Author
deepak1556
Original PR Status
Merged
Original PR Merged At
Sep 28, 2026, 12:35:50 PM
Original PR Link
GitHubView on GitHub

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron