This is a backport PR for branch 42-x-y
#54722: test: wait for child output before asserting on it
Merged
Description of Change
Manually backport #54507.
See that PR for details.
Backport notes
Cherry-picked from the 43-x-y backport, #54543, which conflicts less than the original.
spec/node.spec.ts: dropped the hunk for theprocess.exittests, which42-x-ydoesn't have.spec/lib/msix-helpers.ts:42-x-ystill has the callback form ofspawn(), because #53426's conversion is in its own backport PR. I applied the same'exit'to'close'change to that form. Whichever of the two PRs merges second needs a one-line rebase there.
Validation
On a Linux testing build of 42-x-y (v42.11.12):
e teston all 12 changed spec files: 1081 passed, 7 failed.- The same 7 tests fail the same way on unmodified
42-x-yon this machine, so this change didn't cause them. They are--lang(×3),window.openchild size,document.hasFocus, theprotocol.handle"is fast" ratio, and the js2c fuse test, which needschrome-sandbox. tsc -p tsconfig.spec.jsonpasses.
🤖 Generated with Claude Code
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backport Information
Backported from
#54507: test: wait for child output before asserting on itOriginal PR Author
deepak1556Original PR Status
Merged
Original PR Merged At
Sep 28, 2026, 12:35:50 PM
Original PR Link
View on GitHubSemver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron