#55010: refactor: remove about 90 unnecessary pass-through methods
Merged
Description of Change
api::BaseWindow has about 90 methods that are pure pass-throughs to their api::NativeWindow counterparts, e.g. a JS BaseWindow.foo() call binds to BaseWindow::Foo() { window_->Foo(); }.
Our gin converter already converts from BaseWindow to NativeWindow, so manually marshalling these calls isn't necessary, we can bind directly to NativeWindow.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, past tense, and no longer than 80 characters.
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron