Electron Releases

Description of Change

With a setCertificateVerifyProc installed, two requests to the same host issued together on a fresh session could disagree: one went through the proc while the other occasionally completed on Chromium's own verification result, e.g. rejecting with ERR_CERT_AUTHORITY_INVALID even though the proc accepts the certificate. Retrying a moment later always worked.

RemoteCertVerifier only handed a verification to the proc from the upstream verifier's completion callback, and that callback isn't run when the upstream verifier answers synchronously, which the inner CachingCertVerifier does on a cache hit while an earlier verification of the same certificate is still waiting on the proc. This forwards synchronous upstream results to the proc as well.

Added a session spec that opens the second connection from inside the proc for the first one, which hit the window every time before the change.

Checklist

• I have built and tested this change
• I have filled out the PR description
• I have reviewed and verified the changes
• npm test passes
• tests are changed or added

Release Notes

Notes: Fixed setCertificateVerifyProc occasionally not being applied to a request issued concurrently with the first request to a host.