Electron Releases

Description of Change

Windows opened by middle- or modifier-clicking a link were assembled in JS from a -new-window event with new BrowserWindow(options), so unlike window.open() popups they didn't pick up the opener's session or inherited webPreferences and landed in the default session with defaults.

This creates those windows the same way window.open() popups are created: OpenURLFromTab runs -will-add-new-contents, creates the WebContents in the opener's browser context with the handler's preferences, and hands it to -add-new-contents.

• removes -new-window, the guest-less branch of openGuestWindow and the internal openerSandboxFlags preference (flags go straight onto CreateParams)
• createWindow now always receives options.webContents; docs example updated
• AddNewContents reports a rejected window via was_blocked so it isn't navigated

Checklist

• I have built and tested this change
• I have filled out the PR description
• I have reviewed and verified the changes
• npm test passes
• tests are changed or added
• relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, past tense, and no longer than 80 characters.

Release Notes

Notes: Fixed link-opened windows not using the opener's session and webPreferences.