Electron Releases

Back to PR Lookup
GitHubView on GitHub
jkleinsc

#55408: test: block spellchecker dictionary downloads in specs

Merged
jkleinsc
Created: Oct 27, 2026, 4:28:57 PM
Merged: Oct 28, 2026, 6:21:42 PM
5 comments
Target: main

Requested by John Kleinschmidt · Slack thread

Description of Change

Every Electron session sets a default spellcheck language and, on Linux, downloads the matching hunspell dictionary from redirector.gvt1.com when it isn't cached. The spec runner gives each worker a fresh userData directory, so every test job made several outbound calls to Google's download CDN, which egress monitoring on the CI runners flags. This maps redirector.gvt1.com to NOTFOUND in the spec runner's host resolver rules so those downloads fail locally; the spellchecker specs are unaffected because they serve dictionaries from a local server.

Fixture apps that specs spawn with their own command line don't inherit this rule.

Checklist

  • I have filled out the PR description
  • npm test passes

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vf2yMtuie1dvyPA7pNGXn4

Release Notes

Notes: none

Generated by Claude Code

Backports

43-x-y
Merged
PR Number
#55448
Merged At
Oct 28, 2026, 7:32:53 PM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#55449
Merged At
Oct 28, 2026, 7:40:11 PM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#55450
Merged At
Oct 28, 2026, 7:34:17 PM
Released In
Not yet
Release Date
Not yet
46-x-y
Merged
PR Number
#55451
Merged At
Oct 28, 2026, 7:33:21 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron