dsanders11

#55414: chore: remove redundant methods in ElectronExtensionsRendererClient

Merged
Created: Oct 27, 2026, 11:29:51 PM
Merged: Oct 28, 2026, 1:26:41 PM
4 comments
Target: main

Description of Change

These were moved to the base class upstream in https://chromium-review.googlesource.com/c/chromium/src/+/5789568 so these have been shadowing the methods ever since. Should have no functional change as our methods did the same thing as upstream, but will prevent any future problems.

Identified by the bugprone-derived-method-shadowing-base-method clang-tidy check I'm working to enable, but this was a clean carve off into its own PR while I work through the remaining changes there.

Checklist

  • I have built and tested this change
  • I have filled out the PR description

Release Notes

Notes: none

Backports

44-x-y
Pending
Waiting for a manual backport
45-x-y
Pending
Waiting for a manual backport
46-x-y
Merged
PR Number
#55430
Merged At
Oct 28, 2026, 7:15:36 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron