jkleinsc

#55425: test: avoid launching Edge in shell.openExternal specs on Windows

Merged
Created: Oct 28, 2026, 9:22:32 AM
Merged: Oct 29, 2026, 2:44:52 AM
7 comments
Target: main

Requested by John Kleinschmidt · Slack thread

Description of Change

The shell.openExternal() specs opened a local http URL in the runner's default browser, which is Edge on the Windows CI runners. Edge then made outbound connections to Google update hosts (e.g. clients2.googleusercontent.com) that the CI egress monitor flagged. On Windows the specs now register a temporary per-user URL scheme under HKCU\Software\Classes whose handler runs curl.exe against the local test server, so ShellExecute is still covered and the existing request assertion still holds, but no browser is launched. The handler ignores the opened URL, so nothing from it reaches the command line, and the key is removed after the suite. Since nothing launches Edge anymore, the afterAll that killed msedge is gone. macOS and Linux are unchanged.

Checklist

Release Notes

Notes: none


Generated by Claude Code

Backports

43-x-y
Merged
PR Number
#55477
Merged At
Oct 29, 2026, 9:31:39 AM
Released In
Not yet
Release Date
Not yet
44-x-y
Merged
PR Number
#55480
Merged At
Oct 29, 2026, 9:34:55 AM
Released In
Not yet
Release Date
Not yet
45-x-y
Merged
PR Number
#55478
Merged At
Oct 29, 2026, 9:34:02 AM
Released In
Not yet
Release Date
Not yet
46-x-y
Merged
PR Number
#55479
Merged At
Oct 29, 2026, 9:30:43 AM
Released In
v46.0.0-alpha.3
Release Date
Oct 29, 2026, 3:00:25 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron