jkleinsc

#55658: test: use runner timeout for DevTools indexing lifecycle waits

Merged
Created: Nov 6, 2026, 2:30:35 PM
Merged: Nov 8, 2026, 11:04:29 PM
4 comments
Target: main

Description of Change

The cpp-heap DevTools indexing test could fail when waiting for DevTools to open or WebContents to be destroyed because each wait had a fixed 10-second deadline. These deadlines were shorter than the runner's overall test timeout and did not scale with the longer timeout used by sanitizer builds.

Remove those internal deadlines and let the runner enforce the test timeout. Both lifecycle events must still occur, and retries remain disabled for the entire cpp-heap suite.

Add stderr diagnostics before and after each wait so a stalled remote call identifies which lifecycle event is pending.

Checklist

Release Notes

Notes: none

Backports

44-x-y
Pending
Waiting for a manual backport
45-x-y
Pending
Waiting for a manual backport
46-x-y
Merged
PR Number
#55672
Merged At
Nov 9, 2026, 12:13:28 AM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron