#55941: build: replace the loading benchmark page and keep partial benchmark results
Merged
Requested by John Kleinschmidt · Slack thread
Description of Change
Two benchmark changes (this also rolls in #55857):
- New page for
loadingandtrace. The old synthetic page ran a 3,000,000-iterationMath.sqrtloop before its first paint, so its numbers mostly timed renderer setup plus that loop. It is replaced by a page shaped like a typical Electron app's first window, generated at run time from a fixed seed (no network, fonts or third-party code) and loaded fromfile://: external stylesheets, a few hundred KiB of module-style scripts with a small virtual DOM and store, and a JSON file it renders as a sidebar and a 1,200-row list. Metric names stay the same (loading.first_load.*,loading.reload.*,trace.first_load.*,trace.resize.*), with newapp_readyandlcpmeasures, so those series step at the merge date. - Partial results in
--best-effortruns. The stories that completed in a failed crossbench run are kept, only stories with no complete results in either of the first two rounds stop running (the whole suite only when that is every story), and stories crossbench reported errors for are left out. GPU and renderer memory that can't be attributed (Electron 35–41) is left out and noted instead of being reported as 0 MiB.
After this merges, one full Benchmarks History dispatch with the default majors and suites rebuilds the loading and trace series and fills the file_loading and memory gaps from the first history run.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
- tests are changed or added
Release Notes
Notes: none
Generated by Claude Code
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron